slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

Should the APITestRequest class have a `foo` property? #1243

Closed filmaj closed 9 months ago

filmaj commented 9 months ago

See this code: https://github.com/slackapi/java-slack-sdk/blob/main/slack-api-client/src/main/java/com/slack/api/methods/request/api/ApiTestRequest.java#L14-L17

Should this be included?

seratch commented 9 months ago

@filmaj The request object has the property just to demonstrate how the args property can be returned in its response: https://github.com/slackapi/java-slack-sdk/blob/v1.36.1/slack-api-client/src/main/java/com/slack/api/methods/response/api/ApiTestResponse.java#L11-L15 It's also possible to change it to have a Map object for more dynamic value examples, but I don't think it's so important for many people.

filmaj commented 9 months ago

Oh ok, thanks for explaining. 🙇