slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

A bug on the metric calculation inside async API clients #1269

Closed seratch closed 7 months ago

seratch commented 7 months ago

As mentioned at https://github.com/slackapi/java-slack-sdk/pull/1268, the second line of code in this internal method seems to set an invalid value for the queue size: https://github.com/slackapi/java-slack-sdk/blob/v1.37.0/slack-api-client/src/main/java/com/slack/api/rate_limits/metrics/impl/BaseMemoryMetricsDatastore.java#L273-L274

The code should be corrected without any side effects to the current behavior.