slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

Fix #1271 Add slack_file object to image block / block element classes #1272

Closed seratch closed 7 months ago

seratch commented 7 months ago

This pull request resolves #1271

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fdab0f2) 74.36% compared to head (245f07d) 74.30%.

Files Patch % Lines
.../model/kotlin_extension/block/ImageBlockBuilder.kt 50.00% 4 Missing :warning:
...ension/block/composition/SlackFileObjectBuilder.kt 80.00% 2 Missing :warning:
...api/model/block/composition/BlockCompositions.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1272 +/- ## ============================================ - Coverage 74.36% 74.30% -0.06% - Complexity 4125 4128 +3 ============================================ Files 443 444 +1 Lines 13080 13102 +22 Branches 1323 1323 ============================================ + Hits 9727 9736 +9 - Misses 2580 2594 +14 + Partials 773 772 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seratch commented 7 months ago

Thanks for the quick review!