slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
570 stars 209 forks source link

Kotlin extension should be populated with an earlier api target #1277

Closed rocketraman closed 7 months ago

rocketraman commented 7 months ago

The Kotlin extension is compiled against 1.9.x and by default can only be used by Kotlin 1.9 and above.

Unless the extension is using language features that are only accessible in 1.9.x, I recommend setting the apiVersion on the kotlin compiler, which will allow it to generate code with earlier metadata (recommend 1.6.x) and be usable for users with earlier versions of Kotlin.

See https://kotlinlang.org/docs/maven.html#attributes-specific-to-jvm, specifically languageVersion.

Category (place an x in each of the [ ])

seratch commented 7 months ago

Thanks for the suggestion! Indeed, this could be improved for Kotlin users.

rocketraman commented 7 months ago

Thanks for the suggestion! Indeed, this could be improved for Kotlin users.

@seratch I submitted a PR. No code changes were required to maintain language and API compat with Kotlin 1.6.

rocketraman commented 7 months ago

(BTW, the kotlin label on this repo is spelled incorrectly)

seratch commented 7 months ago

(BTW, the kotlin label on this repo is spelled incorrectly)

🤦 Oops, thanks! Fixed.