slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
573 stars 214 forks source link

Fix #1314 files.upload v2 method does not upload multiple files with full metadata #1316

Closed seratch closed 4 months ago

seratch commented 4 months ago

This pull request resolves #1314 . The actual issue is lack of some metadata in uploaded files for the reported pattern. Uploading files itself is successful but some of its metadata like filename are not properly set.

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (c97f5aa) to head (94ff092).

Files Patch % Lines
.../com/slack/api/methods/impl/MethodsClientImpl.java 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1316 +/- ## ============================================ - Coverage 74.92% 74.90% -0.02% Complexity 4129 4129 ============================================ Files 443 443 Lines 12789 12791 +2 Branches 1319 1319 ============================================ - Hits 9582 9581 -1 - Misses 2439 2441 +2 - Partials 768 769 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.