slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
573 stars 214 forks source link

Add conversations.externalInvitePermissions.set API support #1330

Closed seratch closed 3 months ago

seratch commented 3 months ago

This pull request adds a new endpoint to this SDK: https://api.slack.com/methods/conversations.externalInvitePermissions.set

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

seratch commented 3 months ago

@filmaj The JSON data output will be necessary for Node SDK work. If you don't see any issues with the changes here, please feel free to merge this PR into main branch tomorrow

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.93%. Comparing base (1b6030e) to head (31e4863).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1330 +/- ## ============================================ + Coverage 74.91% 74.93% +0.01% - Complexity 4171 4176 +5 ============================================ Files 446 446 Lines 12902 12912 +10 Branches 1331 1331 ============================================ + Hits 9665 9675 +10 Misses 2461 2461 Partials 776 776 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seratch commented 3 months ago

The e2e tests in this repo automatically detect missing properties plus generate JSON files for you.

You need to set up necessary env variables to run the tests but no need to perfectly set up all the things. When you add a new test with sufficient tokens, running the test generates the sample files based on the latest responses from Slack API server.

filmaj commented 3 months ago

Awesome! Thank you for confirming 🙇