slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
568 stars 210 forks source link

Add missing event data types #1332

Closed seratch closed 2 weeks ago

seratch commented 2 weeks ago

While auditing the latest updates on the platform, I found that a few events are not yet supported in this SDK.

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.95%. Comparing base (2bae6fb) to head (ad2d6ec).

Files Patch % Lines
.../app_backend/events/handler/AppDeletedHandler.java 0.00% 2 Missing :warning:
...pp_backend/events/handler/AppInstalledHandler.java 0.00% 2 Missing :warning:
...kend/events/handler/AppUninstalledTeamHandler.java 0.00% 2 Missing :warning:
...ackend/events/handler/FunctionExecutedHandler.java 0.00% 2 Missing :warning:
...s/handler/SharedChannelInviteRequestedHandler.java 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1332 +/- ## ============================================ - Coverage 75.02% 74.95% -0.07% + Complexity 4187 4186 -1 ============================================ Files 446 451 +5 Lines 12920 12930 +10 Branches 1331 1331 ============================================ - Hits 9693 9692 -1 - Misses 2455 2466 +11 Partials 772 772 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seratch commented 2 weeks ago

FYI for reviewers, all you need to do for Events API are 1) add event classes 2) add payload wrapper classes. Once they are added, you can refer to them in bolt-java without any changes on bolt-java side.