search

slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language
https://slack.dev/java-slack-sdk/
MIT License
571 stars 212 forks source link

fix filename & title getting improperly defaulted in filesUploadV2 #1346

Closed Cheos137 closed 3 weeks ago

Cheos137 commented 1 month ago

fix filename & title getting improperly defaulted when uploading multiple files using MethodsClientImpl#filesUploadV2

fixes #1345

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

salesforce-cla[bot] commented 1 month ago

Thanks for the contribution! Before we can merge this, we need @Cheos137 to sign the Salesforce Inc. Contributor License Agreement.

zimeg commented 1 month ago

Hi @Cheos137! 👋 Thank you for taking the time to send in this PR and sign the CLA!

This logic is looking solid to me but we might want to include a test to ensure this behavior is correct and doesn't regress in future changes 🙏

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.99%. Comparing base (71ed00d) to head (a50d102). Report is 3 commits behind head on main.

Files Patch % Lines
.../com/slack/api/methods/impl/MethodsClientImpl.java 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1346 +/- ## ========================================= Coverage 74.98% 74.99% Complexity 4189 4189 ========================================= Files 451 451 Lines 12930 12929 -1 Branches 1331 1331 ========================================= Hits 9696 9696 + Misses 2463 2462 -1 Partials 771 771 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cheos137 commented 4 weeks ago

cuz i suspect there might not have gone out a notification from it: yesterday i've added tests to this pr