Java 9+ Modularity Supports

slackapi / java-slack-sdk

Slack Developer Kit (including Bolt for Java) for any JVM language

https://slack.dev/java-slack-sdk/

MIT License

573 stars 214 forks source link

Java 9+ Modularity Supports #198

Open denismakogon opened 5 years ago

denismakogon commented 5 years ago

trying out a simple slack API within a module, but seeing this problem

Error: Modules jslack.api.client and jslack.api.model export package com.github.seratch.jslack.common.json to module okio

it doesn't seem like jslack was ever adjusted to work with Project Jigsaw (java 9 modules).

seratch commented 5 years ago

Thank you for your feedback. Honestly, I'm not familiar with making libraries compatible with Java modules yet but I'd love to make jslack modules-ready. Could you help me?

seratch commented 5 years ago

I revisited this issue a little bit but let me hold working on this. I would like to continue supporting Java 8 for a while.

jhg023 commented 5 years ago

@seratch I'd be happy to submit a pull request to fix this, while still maintaining Java 8 compatibility.

tvladyka-photobox commented 2 years ago

That is really needed thing, we unable to use in the project slack-api-client together with slack-api-model in project due to lack of modularity support [ERROR] module <our-module> reads package com.slack.api.meta from both slack.api.client and slack.api.model

sebastien-lamps commented 2 years ago

Tricky thing to make slack API compatible with Java Module system:

Same "public" packages are present in 2 jars: "com.slack.api.meta" and "com.slack.api.util.json"
slack-api-model uses internal class from Google GSON dependency (as workaround for a bug)

bsalture commented 9 months ago

Dear Slack Devs, what is the state of this issue? It still produces error in module-info.java when using your client lib. When do you plan to fix this? Thx Benjamin

grafik grafik