slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node
MIT License
133 stars 41 forks source link

Handle promise return for options / typeahead #24

Closed Startouf closed 6 years ago

Startouf commented 6 years ago

Summary

Allows to respond to typeahead / slack options (see Populate message menus dynamically) via a Promise. PR for https://github.com/slackapi/node-slack-interactive-messages/issues/23

Requirements (place an x in each [ ])

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 6 years ago

Codecov Report

Merging #24 into master will decrease coverage by 0.58%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   32.51%   31.92%   -0.59%     
==========================================
  Files           3        3              
  Lines         163      166       +3     
==========================================
  Hits           53       53              
- Misses        110      113       +3
Impacted Files Coverage Δ
src/adapter.js 35.34% <0%> (-0.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4a1ac1...bf19d7b. Read the comment docs.

aoberoi commented 6 years ago

@Startouf this looks super interesting! i'm sorry nobody got back to you for so long, but i'm taking a look at this right now.

aoberoi commented 6 years ago

I left some comments in #23 about this solution and an idea for something a little more generic.

aoberoi commented 6 years ago

@Startouf thank you for getting started on this effort! I’m closing this PR because it’s superseded by #28