Closed aoberoi closed 6 years ago
Merging #28 into master will increase coverage by
46.55%
. The diff coverage is92.3%
.
@@ Coverage Diff @@
## master #28 +/- ##
===========================================
+ Coverage 32.51% 79.06% +46.55%
===========================================
Files 3 3
Lines 163 172 +9
===========================================
+ Hits 53 136 +83
+ Misses 110 36 -74
Impacted Files | Coverage Δ | |
---|---|---|
src/express-middleware.js | 14.63% <0%> (-0.76%) |
:arrow_down: |
src/util.js | 100% <100%> (+45.45%) |
:arrow_up: |
src/adapter.js | 99.14% <100%> (+62.86%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a4a1ac1...93558ad. Read the comment docs.
in the interest of building new features on top of this branch, and since there aren't yet any reviewers with specific expertise in this module, i'm going to merge. general JS code review still welcome!
Summary
fixes #23 fixes #25
adds two new configuration options for SlackMessageAdapter:
syncResponseTimeout
- number of milliseconds to wait before flushing a syncrhonous response to an incoming request and falling back to an asynchronous response.lateResponseFallbackEnabled
- whether or not promises that resolve after thesyncResponseTimeout
can fallback to a request for theresponse_url
. this only works in cases where the semantic meaning of the response and theresponse_url
are the same.this impacts the table in #27 by making it look like the following:
cb(): Message
cb(): Promise<Message>
respond(m: Message)
respond(m: Promise<Message>)
response_url
requestresponse_url
request (can be used several times)response_url
request (can be used several times) - not a replacement, used as follow upTODO:
respond()
with a Promise (maybe)Requirements (place an
x
in each[ ]
)