Added dist directory - Githubissues

slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node

MIT License

133 stars 41 forks source link

Added dist directory #4

Closed Tom-Alexander closed 7 years ago

Tom-Alexander commented 7 years ago

Summary

Prevents the dist directory from being ignored, which includes the entry point specified in the package.json.

Requirements

[x ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x ] I've read and agree to the Code of Conduct.

CLAassistant commented 7 years ago

All committers have signed the CLA.

aoberoi commented 7 years ago

thanks for the contribution @Tom-Alexander. it turns out this isn't actually the problem. the existence of an .npmignore file should solve the need for explicitly adding these files to git by removing it from .gitignore. in fact, we don't want this change because that would put generated content (which has a tendency to go out of sync) back into the git repo. the real solution is that we need to explicitly run the build before distributing (#14)