slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node
MIT License
133 stars 41 forks source link

Use an npmignore file to only publish the output of babel to npm #54

Closed aoberoi closed 6 years ago

aoberoi commented 6 years ago

Description

Recently we ran into some security issues in another package because npm publish will tar any files in the project directory, even the ones that are git ignored. Since this wasn't clear until npm@6, we didn't notice that random local files were being uploaded into the package.

On top of security, this would decrease the package size significantly, which is a big win.

Requirements

shaydewael commented 6 years ago

Fixed with v1.0.0 😸