slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node
MIT License
133 stars 41 forks source link

fix body parsing miss symbol #74

Closed predator-1 closed 5 years ago

predator-1 commented 5 years ago

Summary

Express Middleware can't parse body of http request. One symbol was missed.

Requirements (place an x in each [ ])

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

predator-1 commented 5 years ago

I signed

aoberoi commented 5 years ago

@predator-1 I can see why this would be confusing, but this is not a bug. This package doesn’t support being later than the body parsing middleware in express intentionally. If the body is parsed, we cannot reliably compute the appropriate request signature, which means the request can not be verified.

You should be able to use express’s routing API to mount this package’s middleware without interfering with the rest of your application (where you might use body parsing).