search

slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node
MIT License
133 stars 41 forks source link

Fix block kit matching logic #89

Closed shaydewael closed 5 years ago

shaydewael commented 5 years ago

Summary

The logic for matching blockIds and actionIds wasn't working because the adapter was looking at the payload's top level rather than in the actions[] array. This should fix that and adds tests.

Requirements (place an x in each [ ])

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   99.14%   99.18%   +0.03%     
==========================================
  Files           3        3              
  Lines         234      244      +10     
==========================================
+ Hits          232      242      +10     
  Misses          2        2
Impacted Files Coverage Δ
src/adapter.js 99.4% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd6edfa...51b1677. Read the comment docs.