search

slackapi / node-slack-interactive-messages

Slack Buttons, Menus, and Dialogs made simpler for Node
MIT License
133 stars 41 forks source link

Allow request verification using req.rawBody (issue #91) #92

Closed ErwinAI closed 5 years ago

ErwinAI commented 5 years ago

Summary

Fixes issue #91

Requirements (place an x in each [ ])

codecov[bot] commented 5 years ago

Codecov Report

Merging #92 into master will decrease coverage by 1.13%. The diff coverage is 92.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   99.18%   98.04%   -1.14%     
==========================================
  Files           3        3              
  Lines         244      256      +12     
==========================================
+ Hits          242      251       +9     
- Misses          2        5       +3
Impacted Files Coverage Ξ”
src/adapter.js 99.38% <100%> (-0.03%) :arrow_down:
src/http-handler.js 95% <92.3%> (-3.39%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 0982098...f2a1b87. Read the comment docs.

billyjs commented 5 years ago

any update to when this will be merged

leoschet commented 5 years ago

Are there any necessary changes to be made before this can be merged?

Edit: I am using this pull request version and until now I have found no errors regarding the implementation.

shaydewael commented 5 years ago

Hey @ErwinLengkeek πŸ‘‹ Apologies it has been so long until we got around to this issue. We've been doing work to move this package over to a new repository where someone has opened a PR that performs the same functionality: https://github.com/slackapi/node-slack-sdk/pull/800

We're grateful that you spent time contributing this and we intend to acknowledge your work in the release notes when we merge and release this feature. Thank you for being a contributor and we'll try to get this feature merged ASAP πŸ™‡πŸ™‡β€β™€

I'm going to close this issue for now, but if anyone wants to follow along, you can watch https://github.com/slackapi/node-slack-sdk/pull/800