search

slackapi / node-slack-sdk

Slack Developer Kit for Node.js
https://slack.dev/node-slack-sdk
MIT License
3.27k stars 662 forks source link

Prep for major release of rtm-api #1764

Closed filmaj closed 6 months ago

filmaj commented 6 months ago

Mainly updating dependencies and dropping support for node below 18.

BUT! I am worried that this package has no tests. Esp. since I updated to the latest major of websockets which has some breaking changes.

Can I manually test an RTM app these days? I have no idea. EDIT: YES it's possible! I tested a RTM app w/ the old package prior to this change, works fine. Also tested it with the changes in this PR, also works OK!

~Another thought: maybe I copy the basic web socket server integration test suite I added to the socket mode package into here (or factor the server out into a utils/ dir or something in this repo and re-use it in both packages?). Then I could at least add some smoke test-style integration tests? That should in theory also be able to write a test for #842 and thus feel confident about a fix.~ I did this! This package now includes basic integration tests. I was able to even add a test to confirm #842 is an issue and added a fix that passes the test 😄

filmaj commented 6 months ago

@hello-ashleyintech I added the tests here!