search

slackapi / node-slack-sdk

Slack Developer Kit for Node.js
https://slack.dev/node-slack-sdk
MIT License
3.26k stars 656 forks source link

types: Add "slack_file" object to "image" block/element types #1783

Closed hi1280 closed 2 months ago

hi1280 commented 2 months ago

Summary

Add "slack_file" object to the types package.

fix: https://github.com/slackapi/node-slack-sdk/issues/1734, https://github.com/slackapi/node-slack-sdk/pull/1738

Requirements (place an x in each [ ])

salesforce-cla[bot] commented 2 months ago

Thanks for the contribution! Before we can merge this, we need @hi1280 to sign the Salesforce Inc. Contributor License Agreement.

hi1280 commented 2 months ago

The following pull request has not been updated for a while, so I have made an additional fix. https://github.com/slackapi/node-slack-sdk/pull/1738

seratch commented 2 months ago

@hi1280 Thanks for taking the time to send this PR! @filmaj The additional change in this PR resolves the remaining code formatting issue in #1738 and it looks good to me. Can you take a look?

filmaj commented 1 month ago

FYI the fix for this has been released to npm as @slack/types v2.12.0.