Closed zimeg closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.63%. Comparing base (
1938408
) to head (8358a43
).
BTW I can build the docs just fine on my machine - hit me up if you need help with getting that set up.
@filmaj and thank you for reviewing! I added all of the additional detail from your suggestions - this is super helpful context to share! 🙌 Going to go ahead with merging! 🚀
I'm also planning to spend a few quality hours with the dotfiles this weekend, but will let ya know once I realize the troubles I've gotten myself into are too much to fix 😳 I have a not-so-easy fix planned for pages and dependencies...
Summary
This PR makes a few changes to the docs around file uploading to suggest using the
filesUploadV2
method first and sharing migration steps later. Response details are also added and a header fix is made for the sidebar navigation.Preview
I had some trouble running a local copy of the docs... Will look into this later but the supported ruby and gem versions for github pages aren't such well supported versions.
I'd recommend building the site if you can, but reading markdown is always an option! If you can build on your machine, a check of the sidebar would be super appreciated too.
Current: https://slack.dev/node-slack-sdk/web-api#upload-a-file
Testing
The code snippets in the docs can be useful for testing, but your own token would be needed.
Notes
Found some confusion in the
result.files
of the response fromfilesUploadV2
. Will write more in an issue, but these docs are purposely vague on the exact response shape.Requirements