Closed davidlj95 closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.62%. Comparing base (
bb21de9
) to head (f352c99
). Report is 3 commits behind head on main.:exclamation: Current head f352c99 differs from pull request most recent head f98f005
Please upload reports for the commit f98f005 to get more accurate results.
Hey this looks good to me and thank you for the PR!
One note about #1769 is that we'll want to add this to all methods that accept all optional arguments. Here's a brief search I did just based on the tests where the changes in this PR would apply:
Thanks! 😊 Oh nice then 💪 I just did a few as kind of a demo of what I'd look like. If looks good, will apply it around. Thanks for searching the places where changes are needed
btw I'm thinking about adding some utility like
type OptionalArgument<T> = T | void
So the intention is more explicit and can easily be refactored around in case we need to detect in which places args are optional
Would you be able to add the same changes to all of the above methods that support purely optional arguments?
Sure!
Summary
Suggest an implementation for #1769 by using
void
& union typesIntroduced
OptionalArgument
for explicitnessFixes #1769
To pay special attention:
Requirements (place an
x
in each[ ]
)