Closed varmil closed 2 months ago
Thanks for the contribution! Before we can merge this, we need @varmil to sign the Salesforce Inc. Contributor License Agreement.
@varmil Could you sign your CLA (see the above bot message)? Without that, we are unable to accept any external contributions 🙇
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.63%. Comparing base (
a7cc255
) to head (d270fe6
). Report is 1 commits behind head on main.
Thank you for your prompt confirmation. I have completed the CLA. Is this okay?
Yes, good to go! Other members in my team will be checking this PR soon. Thanks again for taking the time to fix this!
Took me a bit to understand why this solution works, but it seems like references to MessageEvent
inside message.ts
refer to the built-in node MessageEvent
interface and not the Slack one:
I will look to add a type test in a follow-up PR to catch this. Thank you!
Summary
This pull request resolves #2020
Requirements (place an
x
in each[ ]
)