Closed filmaj closed 2 weeks ago
Attention: Patch coverage is 82.96296%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 91.65%. Comparing base (
1be7a9e
) to head (4ec7f60
). Report is 11 commits behind head on main.
Just wondering, how were the Windows e2e tests verified? (Are we able to run them in CircleCI with a given version of the cli-test package?)
Edit: Ah, I see: https://github.com/slackapi/platform-devxp-test/pull/151
@vegeris I have a PR using this branch of cli-test
in the relevant repo up here: https://github.com/slackapi/platform-devxp-test/pull/151
The two most recent CircleCI runs for this branch show both the non-windows (e2e-test
) and windows (windows-e2e-test
) results: https://app.circleci.com/pipelines/github/slackapi/platform-devxp-test?branch=cli-test-pshell
The windows-e2e-test
job I triggered manually via the CircleCI UI from the same link: https://app.circleci.com/pipelines/github/slackapi/platform-devxp-test?branch=cli-test-pshell
Summary
(FYI a majority of changes in this PR are relatively cosmetic - will post comments for areas of particular interest for the kind reviewer)
There is a (technically) breaking change in this PR: the string arguments passed to
SlackCLIProcess
should be arranged in an array now, and these are passed as the second argument intochild_process.spawn
. This, in combination with the following changes, also fixes thedatastore
commands on Windows:cmd.exe /c /s
invocation, which helps to manage how node will strip quotes out of arguments on Windows when passed tochild_process
APIs.TODO: