search

slackapi / python-slack-events-api

Slack Events API adapter for Python (Flask required)
https://api.slack.com/events
MIT License
343 stars 116 forks source link

[MINOR] Decode byte stream into utf-8 #18

Closed navinpai closed 6 years ago

navinpai commented 7 years ago

Summary

Fixes #17

The Slack challenge token response is received as bytestream not str. This breaks in Python 3.x. As a fix, we simply decode the stream to string, and everything works as expected

Requirements (place an x in each [ ])

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 7 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files           3        3           
  Lines          30       30           
=======================================
  Hits           26       26           
  Misses          4        4
Impacted Files Coverage Δ
slackeventsapi/server.py 90% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61310e6...2e80ec0. Read the comment docs.