search

slackapi / python-slack-events-api

Slack Events API adapter for Python (Flask required)
https://api.slack.com/events
MIT License
343 stars 116 forks source link

Accept usage of Flask Blueprints as app instance #56

Closed maryum375 closed 4 years ago

maryum375 commented 5 years ago

Summary

Allowing usage of slack blueprints to setup the SlackServer instance.

Requirements (place an x in each [ ])

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

jlapenna commented 4 years ago

This is something I came across as well which would be nice to merge.

seratch commented 4 years ago

@maryum375 Thank you very much for taking the time to make this pull request. Also, I'm sorry that the team took a very long time (almost one year) until checking it.

I'm moving this forward. I've applied some additional changes to your PR in #69. It would be greatly appreciated if you check it and give us feedback if you have some.

psykzz commented 4 years ago

Any reason that needed to go into a new PR and couldn't have been added to this one? Typically PRs allow repo contributors push access to the branch, so it would've been possible.

If not it would be good to add @maryum375 to the co-authors via Co-authored-by: Ran Mariuma <maryum375@gmail.com>

seratch commented 4 years ago

@psykzz

Any reason that needed to go into a new PR and couldn't have been added to this one? Typically PRs allow repo contributors push access to the branch, so it would've been possible.

Good point. Indeed, it's usually possible but somehow this repository seems to be a bit different. I've walked through the repository settings but haven't found any relevant settings to modify. So, I know it's not ideal but went with a new pull request.

Co-authored-by

Thanks, I didn't know this! I don't think we need to modify my PR a lot but I'll update my commits with this.

Update: To be clear, my PR never removes @maryum375's original contribution as the commit's email hasn't been changed.

psykzz commented 4 years ago

I've walked through the repository settings but haven't found any relevant settings to modify

Its a setting the PR author ticks on the PR to give access, typically i've found its enabled by default, Not in this case though, that's my mistake. See the screenshot below image

Good to hear its included, mostly just curious about the flow.

seratch commented 4 years ago

@maryum375 Thanks for your contribution here. I just shipped 2.2.0rc1, a pre-release version including a fix for this. Please try it out if you have a chance. v2.2.0 will be out soon.