slackapi / python-slack-events-api

Slack Events API adapter for Python (Flask required)
https://api.slack.com/events
MIT License
343 stars 116 forks source link

Remove Python 2.7 compatibility #96

Closed agurgel-te closed 3 years ago

agurgel-te commented 3 years ago

Summary

Fixes #95.

I thought of including a change to fully fix tox, but it seems unused and I didn't want to do too many unrelated things in the PR. Anyway, after the following diff, tox shows a passing result:

diff --git a/tox.ini b/tox.ini
index afdfad4..29d9a49 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14 +13,0 @@ deps =
-    -r{toxinidir}/requirements.txt

Requirements (place an x in each [ ])

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

seratch commented 3 years ago

Hi @antonio-te, thanks for taking the time to make this contribution!

Once your fix is merged, we will release a new version - 3.0.0.

agurgel-te commented 3 years ago

Would you mind signing our CLA? Without having it, we are unable to have your changes in this repo

I wouldn't mind (I read it top-to-bottom, in fact), but I haven't had the occasion to sign one during the course of my work so I'm checking with my team to make doubly sure it's A-OK.

agurgel-te commented 3 years ago

Apologies for the delay; I've gained approval to sign the CLA, and did so just now.

seratch commented 3 years ago

@antonio-te Thanks for working on this! After cleaning up a bit more, we will release v3.0 shortly.