slackapi / python-slack-sdk

Slack Developer Kit for Python
https://tools.slack.dev/python-slack-sdk/
MIT License
3.86k stars 834 forks source link

Download file using WebClient #1434

Open freud14-tm opened 11 months ago

freud14-tm commented 11 months ago

Right now, the only way to download a file from Slack is to do something like this:

import requests
response = requests.get(url_private, headers={"Authorization": f"Bearer {TOKEN}"}, timeout=30)

However, this does not respects the parameters passed to WebClient. We should be able to do something like:

client = WebClient()
response = client.get(url_private)

Or something along those lines.

Category (place an x in each of the [ ])

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

seratch commented 11 months ago

Hi @freud14-tm, thanks for taking the time to share the feedback.

Since the WebClient class is supposed to be used only for https://api.slack.com/methods endpoints, we don't have immediate plans to add something like you suggested. With that being said, adding a useful module for downloading files could be beneficial for many developers. Thus, we may add such in the future. For now, please go ahead with requests library for it.