Why are deprecated methods not commented out or removed?

slackapi / python-slack-sdk

Slack Developer Kit for Python

https://slack.dev/python-slack-sdk/

MIT License

3.83k stars 838 forks source link

Why are deprecated methods not commented out or removed? #1531

Open Keanro opened 1 month ago

Keanro commented 1 month ago

Is there a reason that deprecated methods, such as groups_createChild, are allowed to be called? As the deprecation happened 3.5 years ago, it feels like it's a good time to comment them out or remove it. An old issue had a similar question, but it's not quite the same question.

https://github.com/slackapi/python-slack-sdk/blob/417fc5b269dba776b0ddb60223a756130815292d/slack_sdk/web/client.py#L3840-L3848

seratch commented 1 month ago

Hi @Keanro, thanks for the suggestion! Indeed, there are no blockers for removing them, so we may remove the lines of code in a future release.