slackero / phpwcms

Flexible, fast, powerful, customer, developer friendly web content management system and cms framework
http://www.phpwcms.org
GNU General Public License v2.0
92 stars 45 forks source link

Tabs sorting bricks if more than 4 tabs present #267

Closed q23 closed 5 years ago

q23 commented 5 years ago

Hi Oli,

if you have more than 4 tabs in a tabs content part the sorting in the backend for the tabs below the first 4 stops working.

Message when you click on the sorting symbol below the 4th element in the browser console:

    at d.start (mootools-1.1-yc.js:formatted:3318)
    at a (mootools-1.1-yc.js:formatted:469)
    at HTMLElement.<anonymous> (mootools-1.1-yc.js:formatted:484)

https://github.com/slackero/phpwcms/blob/master/include/inc_tmpl/content/cnt32.inc.php#L375

Hopefully you could look into it and find the problem soon.

best wishes q23

slackero commented 5 years ago

It works for me as expected. Check if commit fc310cdfee650ead0ab6ecbf31f45ced69fcdd14 solves this. I have not tested yet.

q23 commented 5 years ago

Thanks, fixes the issue for us.

q23 commented 5 years ago

The fix does not work if you have a file field present in tabs sorting. I checkt the DOM for the Image output of the tabs in backend, it is valid html with working ids. Maybe the tr > table bricks it somehow? Also the grapical output of this boxes breaks a bit. Screenshot_2019-06-26 phpwcms Backend (Verwaltung) - www profrost com

slackero commented 5 years ago

@q23 can you send me a sample with the related config and template files so I can check myself.

q23 commented 5 years ago

we can provide you ftp and be access as soon as you find the time to check it.

slackero commented 5 years ago

You have my email. I will check locally.

q23 commented 5 years ago

mail done

slackero commented 5 years ago

Should be fixed, also on sample website.

q23 commented 5 years ago

works for us. Thanks!