slackhq / PanModal

An elegant and highly customizable presentation API for constructing bottom sheet modals on iOS.
MIT License
3.67k stars 527 forks source link

UINavigationController fails set the correct .intrinsicHeight of rootViewController #148

Open JMCPH opened 3 years ago

JMCPH commented 3 years ago

Description

When presenting a subclass of UINavigationController which conforms to the PanPresentable, the .intrinsicHeight is always fullscreen and not using the height of the FirstViewController which is the rootViewController of the UINavigationController.

When presenting a FirstViewController using the presentPanModal method, the view is correctly using the height of the content of the FirstViewController.

Is there anyway to get this behaviour?

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

PanModal version: 1.2.7

iOS version: 14.5

Expected result:

The UINavigationController would adjust the height to the rootViewController when being presented using the PanModalPresentable

Actual result:

It didn't adjust the height.

jannemecek commented 2 years ago

Did you end up solving this? We're in a similar spot right now trying to work around this issue.