slackhq / PanModal

An elegant and highly customizable presentation API for constructing bottom sheet modals on iOS.
MIT License
3.69k stars 533 forks source link

Using default present() on top of a PanModal presented view. #151

Open patthehuman opened 3 years ago

patthehuman commented 3 years ago

Description

I am using a PanModal view controller that is 50% height of the device screen. I then present another view controller on top of it using iOS default self.present(). The reason I am using present() and not using PanModal is because I am using a separate transitions library that requires me to use present()

Once I present the view controller using Present, the PanModal view controller changes itsself to full screen and all touches and scroll events are disabled.

What type of issue is this?

Requirements


Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in: latest

PanModal version: latest

iOS version: Using 14+

Steps to reproduce:

  1. Present a PanModal
  2. Present a full screen modal using self.present()
  3. PanModal view controller gets displayed wrong

Expected result:

I expected the PanModal view to be untouched

Actual result:

The PanModal presented view controller gets stretched to full screen and fully breaks pan functionality

patthehuman commented 3 years ago

?

ppamorim commented 3 years ago

@patthehuman You can maybe try to overwrite the main implementation of this library and call the present from this library.