longFormHeight .maxHeight isn't working with safeAreaLayoutGuide

petermumford commented 5 years ago

Swift: 5 XCode: 10.2.1 PanModal: 1.2.4

When I set the longFormHeight to use maxHeight the drag indicator always goes behind the status bar. This happen in any iPhone that needs to use the safeAreaLayoutGuide.

presentPanModal( MyController() )

class MyController: UITableViewController, PanModalPresentable {
  var panScrollable: UIScrollView? {
    return tableView
  }

  var longFormHeight: PanModalHeight {
    return .maxHeight
  }

  var shortFormHeight: PanModalHeight {
    return longFormHeight
  }
}

Let me know if you need any more information from me. Thank you.

ste57 commented 5 years ago

Hi @petermumford

Apologies for the delay! Is this still an issue?

I can't seem to reproduce this & I notice that even though the base VC is a UITableViewController, I don't see any of the tableViewCells in the screenshot - could you provide more details?

Stephen

petermumford commented 5 years ago

Hi @ste57

No problem. However, I need to go back to see what I did for a temporary fix. I'll let you know asap with more details.

ste57 commented 5 years ago

Closing this out for now - feel free to reopen if the issue persists

slackhq / PanModal

longFormHeight .maxHeight isn't working with safeAreaLayoutGuide #38