search

slackhq / SlackTextViewController

⛔️**DEPRECATED** ⛔️ A drop-in UIViewController subclass with a growing text input view and other useful messaging features
https://slack.com/
MIT License
8.32k stars 1.08k forks source link

Strange Swift compiler warnings on UIScrollViewDelegate #176

Closed blakeperdue closed 9 years ago

blakeperdue commented 9 years ago

I am running xCode 6.3.1 (6D1002) and Swift 1.2. I'm targetting iOS 7.0 and above with my app.

I am using cocoapods to install/use SlackTextViewController. I am seeing two very strange Swift compiler warnings: http://cl.ly/image/1a242j412k0u

/apps/SnapSuggest/ios/SlackTextViewController.SLKTextViewController:296:14: Parameter of 'scrollViewDidScroll' has different optionality than expected by protocol 'UIScrollViewDelegate' /apps/SnapSuggest/ios/UIKit.UIScrollViewDelegate:2:23: Requirement 'scrollViewDidScroll' declared here

and

/apps/SnapSuggest/ios/SlackTextViewController.SLKTextViewController:295:14: Parameter of 'scrollViewShouldScrollToTop' has different optionality than expected by protocol 'UIScrollViewDelegate' /apps/SnapSuggest/ios/UIKit.UIScrollViewDelegate:16:23: Requirement 'scrollViewShouldScrollToTop' declared here

Anyone seen this or have any ideas? Googling these errors didn't turn up anything. Thanks in advance.

dzenbot commented 9 years ago

@tomaskraina reported this too in https://github.com/slackhq/SlackTextViewController/issues/173 I haven't been able to see it myself tho.

dzenbot commented 9 years ago

@blakeperdue @tomaskraina did you find a way to get rid of it?

blakeperdue commented 9 years ago

@dzenbot Sadly no. I ended up commenting out the two methods (scrollViewDidScroll and scrollViewShouldScrollToTop) to remove the warnings. This is obviously not a good solution but only thing that temporarily worked for me.

dzenbot commented 9 years ago

See https://github.com/slackhq/SlackTextViewController/issues/173#issuecomment-99531842