Add `SLKTextView` as target to loupe gesture can cause crash.

slackhq / SlackTextViewController

⛔️**DEPRECATED** ⛔️ A drop-in UIViewController subclass with a growing text input view and other useful messaging features

https://slack.com/

MIT License

8.32k stars 1.08k forks source link

Add `SLKTextView` as target to loupe gesture can cause crash. #258

Closed devladinci closed 9 years ago

devladinci commented 9 years ago

Overwriting - (NSArray *)gestures in SLKTextView can cause crash. - (NSArray *)gestures is called when super is being dealloc-ed.

Possible fix: Add self as target during initialisation. See -> https://github.com/devladinci/SlackTextViewController/commit/5abf17a027fa8e6412255df43620fb145fecc7ec

dzenbot commented 9 years ago

That doesn't work on iOS 9. The gestures are recreated over and over. Couldn't find a better solution. Didn't realised that it was causing a crash tho, thanks for the heads up!