UITextViewDelegate methods not being called in 1.9

slackhq / SlackTextViewController

⛔️**DEPRECATED** ⛔️ A drop-in UIViewController subclass with a growing text input view and other useful messaging features

https://slack.com/

MIT License

8.32k stars 1.08k forks source link

UITextViewDelegate methods not being called in 1.9 #372

Closed comptonmc closed 8 years ago

comptonmc commented 8 years ago

I currently use the - (void)textViewDidBeginEditing:(UITextView *)textView method to do some texting if someone is allowed to comment (i.e. are they anonymous or authenticated).

In 1.9 version the TextVewDelegate methods are no longer being called. I have tried directly setting the textInputBar.textView delegate myself and still no callbacks. Reverted back to 1.7 and it works as expected. However, given the private API issues I am embedding this in client code, I don't want to revert back.

dzenbot commented 8 years ago

Same than https://github.com/slackhq/SlackTextViewController/issues/349 This is now fixed in master. Will summit a patch version today 👊 On the mean time, target that commit.

comptonmc commented 8 years ago

You guys rock. Sorry I didn't see the prev bug fix. Thanks!