search

slackhq / SlackTextViewController

⛔️**DEPRECATED** ⛔️ A drop-in UIViewController subclass with a growing text input view and other useful messaging features
https://slack.com/
MIT License
8.32k stars 1.08k forks source link

presentKeyboard not firing #605

Open dfmarulanda opened 7 years ago

dfmarulanda commented 7 years ago

presentKeyboard is not firing when keyboard is presenting. So inputBar keeps hidden in back of the keyboard.

fwx commented 7 years ago

Same here.

ShawnBaek commented 7 years ago

Me too @lsvz @Dfmarulanda Did you solve this problem?

fwx commented 7 years ago

@ShawnBaek Well, I changed visibility of slk_registerNotifications and added it to some places in my controllers, but still sometimes it does not fire.

ShawnBaek commented 7 years ago

@lsvz Thanks for sharing your knowledgement. I solved this problem by remove viewDidAppear methods. But I don't know why this func affect this issues.

fwx commented 7 years ago

@ShawnBaek Yea, I've just seen your issue and tried removing viewDidAppear, but I still do have this. It happens after I present a controller, then tap on textInputBar.

ShawnBaek commented 7 years ago

@lsvz In my experience, I also use this library after present view controller. I hope you to solve the problem.

johndoehelloworld commented 7 years ago

+1 @lsvz : were you able to solve the issue?

fwx commented 7 years ago

@johndoehelloworld no. Currently working on it. I will post here if I find a solution.

fwx commented 7 years ago

@johndoehelloworld I managed to fix adding slk_registerNotifications (you have to change .h file a little bit) after I dismiss the controller.

note that I had bug while opening a controller inside SLKTextViewController (for pictures selection)

tmspzz commented 7 years ago

Any update on this? I'm glad to take a look if no one else has updates

tmspzz commented 7 years ago

I solved this by adding my slackTextViewController as a childViewController of my current VC

fwx commented 7 years ago

Update here. Had to make slk_registerNotifications public and then add self.slk_registerNotifications in viewDidAppear

tditchek commented 7 years ago

I'm also having this issue. Tested on iPhone 6, 8 Plus, and X, all running iOS 11.0.3.

Are there any plans to add the changes @fwx recommends to the library so I can keep using cocoapods to manage this dependency without having to fork it?

tditchek commented 6 years ago

@dzenbot Any updates or workarounds for this issue? It seems to be the cause of issue #615 as well. I've tried the slk_registerNotifications workaround @fwx suggested above, but it's not working for me. Any help would be greatly appreciated. Thanks!