slackhq / astra

Astra is a structured log search and analytics engine developed by Slack and Salesforce
https://slackhq.github.io/astra/
MIT License
213 stars 30 forks source link

Narrow grpc metric collecting decorator to just the grpc services #1069

Closed baroquebobcat closed 3 weeks ago

baroquebobcat commented 2 months ago

Summary

Instead of adding the grpc.service metric decorator to all services declared with the builder, scope it to the grpc service.

When I was looking at the decorator usage a while ago, I noticed that the metric decorator was being added globally in a place that I wouldn't expect it to add a global decorator. This narrows that scope to just the grpc service being added.

Requirements

github-actions[bot] commented 4 weeks ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 3 days.