search

slackhq / compose-lints

Lint checks to aid with a healthy adoption of Compose
https://slackhq.github.io/compose-lints
Apache License 2.0
388 stars 22 forks source link

this doesn't seems right #344

Closed mohammadkahelghi-grabtaxi closed 2 months ago

mohammadkahelghi-grabtaxi commented 4 months ago

https://github.com/slackhq/compose-lints/blob/f1ada1945d037e34b98ac9c33c89b0a99440b0e0/compose-lint-checks/src/test/java/slack/lint/compose/ContentEmitterReturningValuesDetectorTest.kt#L73C8-L81C17

 import androidx.compose.runtime.Composable

        @Composable
        fun Something() {
            Text("Hi")
            Text("Hola")
        }
        @Composable
        fun Something() {
            Spacer16()
            Text("Hola")
        }

function names are same with no args

ZacSweers commented 4 months ago

It doesn't compile but that's not necessarily required for lints. PR is welcome if you want to change it though

ZacSweers commented 2 months ago

Closing as this lacks context, feel free to revisit (with more detail)