slackhq / compose-lints

Lint checks to aid with a healthy adoption of Compose
https://slackhq.github.io/compose-lints
Apache License 2.0
388 stars 22 forks source link

Fix link to multipreview annotations in docs #418

Closed erikghonyan closed 5 days ago

erikghonyan commented 5 days ago

The existing link redirects to https://developer.android.com/develop/ui/compose/tooling#preview-multipreview which is a tooling overview page and doesn't mention multipreviews

salesforce-cla[bot] commented 5 days ago

Thanks for the contribution! Before we can merge this, we need @erikghonyan to sign the Salesforce Inc. Contributor License Agreement.

erikghonyan commented 5 days ago

Thanks Zac! It looks like something didn't go right, I did get a "Something went wrong" when trying to sign it the first time but when I try again it says I've already signed it? 🤷

Screenshot 2024-10-02 at 17 57 20

Is there a way to reset it or something? Otherwise, I can close the PR and you can make the change if you want (would be nice to be able to contribute again though)

ZacSweers commented 5 days ago

Annoyingly, closing/reopening is how we fix this apparently. Thanks!

erikghonyan commented 5 days ago

Heh, nice! 😄