Closed samsaggace closed 3 years ago
Regarding tests, I added the argument to the list of expected arguments, but not that it's really the webpack compilation object, I don't know if it's possible or needed
Merging #81 (f55370b) into master (96491f9) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 108 108
Branches 19 19
=========================================
Hits 108 108
Impacted Files | Coverage Δ | |
---|---|---|
plugin.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 96491f9...f55370b. Read the comment docs.
Repushed : reinstall webpack-sources dependency with node 10 and npm 6 installed to avoid big diff in package-lock.json
Hi @AnujRNair,
I think I have implemented your suggestions but please tell me if there is something else I need to do before this PR could be merged.
Thanks
Once I have had a second to confirm whether a regression was released or not in 5.0.1 as reported in https://github.com/slackhq/csp-html-webpack-plugin/issues/80, I will also release this change to NPM.
Thanks for the contribution!
Summary
Enables to manipulate the webpack build to add an asset file to the build. Discussed in https://github.com/slackhq/csp-html-webpack-plugin/issues/52
Requirements (place an
x
in each[ ]
)