slackhq / goSDL

goSDL
MIT License
523 stars 83 forks source link

check http status code #17

Open jasonmacgowan opened 6 years ago

jasonmacgowan commented 6 years ago

Summary

throws errors on http status codes >=400 so the user knows the expected action failed

fixes (kinda) #16

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

jasonmacgowan commented 6 years ago

This is a start but really we should be more verbose about what actually failed

Also it's possible to do this by setting something like the following" curl_setopt($ch,CURLOPT_FAILONERROR,true);

Maybe that's the default for some people and they weren't encountering this?

fyunaz commented 5 years ago

Hi, thanks for looking at this. Are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=17

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.