slackhq / goSDL

goSDL
MIT License
523 stars 83 forks source link

Add Dockerfile #7

Closed pieterlange closed 5 years ago

pieterlange commented 6 years ago

Summary

Makes it easier to run this software in an isolated environment.

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

pieterlange commented 6 years ago

Please excuse the hack i used to dump the env into the dotenv file. If we can somehow make the app read from the real environment that'd be better but PHP is not really my native language :)

Where can i sign the CLA?

pieterlange commented 6 years ago

@fyunaz Can i do something to unblock this? ;) I assume you're busy.

JoelPagliuca commented 6 years ago

ran the project against this Dockerfile, and can confirm it works

aoberoi commented 5 years ago

@pieterlange are you able to visit the following URL to sign the CLA? https://cla-assistant.io/slackhq/goSDL?pullRequest=7

I think there might be an issue with the service we use, cla-assistant.io, for posting the status check on PRs.

pieterlange commented 5 years ago

CLA works now, thanks for the response @aoberoi