slackhq / goSDL

goSDL
MIT License
523 stars 83 forks source link

CURLOPT_SSL_VERIFYPEER disabled for JIRA integration #9

Closed EricEllett closed 6 years ago

EricEllett commented 6 years ago

Description

Hello friends! It appears that the current JIRA integration doesn't enable certificate verification.

What type of issue is this? (place an x in one of the [ ])

Requirements (place an x in each of the [ ])


Bug Report

It appears that the CURLOPT_SSL_VERIFYPEER parameter in the https://github.com/slackhq/goSDL/blob/master/include/lib_jira.php file is currently disabled for each curl session.

Reproducible in:

goSDL version: 1

{platform_name} version: N/A

OS version(s): N/A

Steps to reproduce:

N/A

Expected result:

N/A

Actual result:

N/A

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

fyunaz commented 6 years ago

Yes, we should do this!