search

slackhq / slack-api-docs

API Docs for Slack.com
https://api.slack.com/
426 stars 85 forks source link

documentation about team_disabled error is missing #40

Closed ernesto-jimenez closed 9 years ago

dblock commented 9 years ago

@ernesto-jimenez Slack said they will not be updating that repo until they hire someone. We don't have to wait. I've pulled JSON files from https://github.com/slackhq/slack-api-docs into https://github.com/dblock/slack-api-ref, which I intend to maintain and kept JSON files only. Would you like to contribute this fix?

ernesto-jimenez commented 9 years ago

Does it have Slack's blessing? Otherwise I would rather wait until they decide to maintain it.

They already have a Job opening for a dev rels, so it shouldn't take too long.

/cc @paulhammond @iamcal

dblock commented 9 years ago

It doesn't, but this is what I got from someone at slack:

screen shot 2015-08-27 at 1 06 50 pm

I am not holding my breath.

dblock commented 9 years ago

Plus if they decide to maintain and actually have someone on it, it I'll be happy to PR all changes. They do maintain the docs on https://api.slack.com, but that repo has clearly been private for a while - I imagine they have no real reason to maintain the JSON schema.

ernesto-jimenez commented 9 years ago

They just started building a bigger platform team recently, so they'll get there. I don't think spreading feedback across different repos would help, and spamming all issues/PR's can get annoying quickly.

dblock commented 9 years ago

Thanks @ernesto-jimenez, do what you feel is right.

mccreath commented 9 years ago

We are documenting this error as we speak, and it will be available in this repo in the next release!

paulhammond commented 9 years ago

Quick update on this one: in the end we didn't document this error. Instead we made the implementation match what the documentation says: if a team is disabled we'll now return an account_inactive error. So you shouldn't see the team_disabled error any more.

Our thinking here is that as an API app developer it doesn't really matter to you if the account is inactive because the account was deleted or because the team was deleted, you're still going to show the same error message to your users.

Thanks for pointing this out!