Improve XHP feature documentation and testing - Githubissues

slackhq / tree-sitter-hack

Hack grammar for tree-sitter

MIT License

33 stars 15 forks source link

Improve XHP feature documentation and testing #23

Closed frankeld closed 3 years ago

frankeld commented 3 years ago

Summary

Add test for XHP spread expression (currently supported).
Add tests for deprecated children/category syntaxes and move to deprecated section.
Make note about use case of XHP attributes with no identifier.

This PR also includes an independent formatting fixup commit.

Class attr test file covers both expressions and declarations but put it in declarations. Happy to move.

Related Links:

Test cases sourced from here: https://github.com/hhvm/xhp-lib/blob/v3.x/tests/ChildRuleTest.php See historical notes here: https://docs.hhvm.com/hack/XHP/extending See XHP PRs/issues: https://github.com/hhvm/xhp-lib/issues/212, https://github.com/hhvm/xhp-lib/pull/276

CLAassistant commented 3 years ago

All committers have signed the CLA.