Closed 4e554c4c closed 2 years ago
@4e554c4c Thanks for the contribution! Happy to update to linguist-generated
. What's the motivation for removing the binary
attribute (rather than keeping them as /src/grammar.json binary linguist-generated
)? Although they are not technically binaries, labeling them as binaries prevents autogenerated noise from clogging diffs. Do you find it more useful to see those changes?
@frankeld Oh I didn't think about git diff. I'm pretty sure that the !diff
attribute would fix this, let me test it out
-diff
will work, as binary
is just a macro for -diff -merge -text
sounds good, mind leaving a review?
The treesitter files are autogenerated and are constantly changing, leading to hundreds of thousands of lines in code review. They are currently marked as "vendored" however this is for code which was manually written but automatically checked in. The
generated
attribute should be used instead so that changes to the files do not appear in code review.see https://github.com/github/linguist/blob/master/docs/overrides.md and https://git-scm.com/docs/gitattributes for more info.
test plan: modify
grammar.js
, runtreesitter generate
and look at diff:Requirements (place an
x
in each[ ]
)npm run test-corpus
to make sure all tests pass.