Add support for expression trees (#59)

slackhq / tree-sitter-hack

Hack grammar for tree-sitter

MIT License

33 stars 16 forks source link

Add support for expression trees (#59) #60

Closed andryak closed 1 year ago

andryak commented 1 year ago

Summary

Add support for expression tree syntax.

This is an experimental Hacklang feature that allows the user to prefix an Hack expression in backticks with a VisitorClass and get an expression as a result.

For instance:

$x = SomeVisitorClass`{ return 42; }`;

is a valid expression tree.

This pull request allows the parser to recognise this syntax.

Requirements

[x] I've added tests for any new code and ran npm run test-corpus to make sure all tests pass.
[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

salesforce-cla[bot] commented 1 year ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Andrea Aquino a***@f***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

muglug commented 1 year ago

Mind merging these into a single PR?

andryak commented 1 year ago

Thanks for checking! Sure, I am travelling today, will do tomorrow :)

On Fri, 25 Aug 2023 at 16:59, Matthew Brown @.***> wrote:

Mind merging these into a single PR?

— Reply to this email directly, view it on GitHub https://github.com/slackhq/tree-sitter-hack/pull/60#issuecomment-1693503260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK2RB3I2KGH4SL4YYZ4KPLXXC4UHANCNFSM6AAAAAA3KJBCOA . You are receiving this because you authored the thread.Message ID: @.***>