Fix parsing for expression tree, module level attrs, include on piped expressions and typed collection initializers (#57, #58, #59, #64) - Githubissues

slackhq / tree-sitter-hack

Hack grammar for tree-sitter

MIT License

33 stars 15 forks source link

Fix parsing for expression tree, module level attrs, include on piped expressions and typed collection initializers (#57, #58, #59, #64) #66

Closed andryak closed 1 year ago

andryak commented 1 year ago

Summary

This PR provides all the features previously addressed by the following PRs for easier merging:

These address issues:

Features / bug fixes:

Correctly parse expression tree syntax (e.g. $x = SomeVisitorClass`some expression`;)
Correctly parse module level import syntax (e.g. <<file: SomeClass(SomeOtherClass::class)>>)
Correctly parse include/require on piped expression (e.g., new Foo() |> $$->include();)
Correctly parse typed collections initializers (e.g., $x = Vector<string> {'foo', 'bar'};)

Requirements

[x] I've added tests for any new code and ran npm run test-corpus to make sure all tests pass.
[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

muglug commented 1 year ago

Thanks!