[BUG] Underscores as digit separators are not supported in the grammar - Githubissues

slackhq / tree-sitter-hack

Hack grammar for tree-sitter

MIT License

33 stars 16 forks source link

[BUG] Underscores as digit separators are not supported in the grammar #72

Open mmanela opened 5 months ago

mmanela commented 5 months ago

Describe the bug

Hack documentation says you can use underscores as digit separators but the grammar errors if you use them.

Requirements

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

To Reproduce

Use an integer with underscore digit separators

 $a = 123_456;

Which currently parses as the following (notice the ERROR)

(expression_statement
        (binary_expression
          left: (variable)
          (ERROR
            (integer))
          right: (qualified_identifier
            (identifier))))

Expected behavior

I expect usage of the underscore digit separator to parse properly.

Saichandra2520 commented 2 months ago

I'm currently working on this issue and will submit a pull request soon. #72