search

slackhq / vscode-hack

Hack language & HHVM debugger support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pranayagarwal.vscode-hack
MIT License
73 stars 36 forks source link

Support window/progress message #24

Open fredemmott opened 6 years ago

fredemmott commented 6 years ago

FB extension.

Signature here: https://github.com/facebook/hhvm/blob/master/hphp/hack/src/utils/lsp.ml#L850

Efforts to standardize this at https://github.com/Microsoft/language-server-protocol/pull/245 and https://github.com/Microsoft/language-server-protocol/issues/511

PranayAgarwal commented 6 years ago

What is the best way to get progress messages from the language server? Any current use case?

fredemmott commented 6 years ago

If they're in clientcapabilities, they should be pushed.

I believe that Hack will push them when initializing if it's not already running; if supported, HHAST could also push them for the whole-repo lint

mroch commented 5 years ago

@fredemmott updated permalink: https://github.com/facebook/hhvm/blob/0c4c1b966bec9cae74d9d35d13ffc93c449fa00a/hphp/hack/src/utils/lsp/lsp.ml#L1007

PranayAgarwal commented 5 years ago

I updated the initialize request to send over the following (in client capabilities):

"workspace": { ... },
"textDocument": { ... },
"window": {
    "status": true,
    "progress": true
}

but still don't get any of those requests from the language server. Anything else I should be doing?