Updated grammar with changes since Aug 2018

slackhq / vscode-hack

Hack language & HHVM debugger support for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=pranayagarwal.vscode-hack

MIT License

76 stars 38 forks source link

Updated grammar with changes since Aug 2018 #69

Closed tspence closed 5 years ago

tspence commented 5 years ago

Some of my colleagues using VSCode have noticed a few syntax highlighting issues, and as it turns out this file is a bit out of date. This diff syncs with the latest formatting.

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Ted Spence seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

PranayAgarwal commented 5 years ago

Thanks @tspence! Unfortunately this file forked from the Atom version a little while ago, and the latest changes are overwritten by this PR (as @fredemmott pointed out).

tspence commented 5 years ago

Thanks @PranayAgarwal - I'm working internally to sync up our latest changes with the latest ones here. I'll update the PR when I've completed the revisions.

tspence commented 5 years ago

For some reason this PR thinks I haven't signed the CLA. I've tried the "please recheck" button a few times without success. I'm going to close this PR and open a new one; with luck the new one will catch the update.